Drop checkpoint files from OS file cache to prevent file cache growing to hundreds of GB #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After reading or creating a checkpoint file, drop it from the OS file cache. This change helps prevent Grafana EN Memory Usage chart from showing hundreds of GB as used because it doesn't exclude the OS file cache. Without this change, checkpointing will add over 100GB to OS file cache each time because each checkpoint file is over 50GB. If GOOS != linux then do nothing.
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
Codecov Report
@@ Coverage Diff @@
## v0.25 #2281 +/- ##
=======================================
Coverage 57.48% 57.49%
=======================================
Files 643 643
Lines 38197 38224 +27
=======================================
+ Hits 21958 21977 +19
- Misses 13447 13450 +3
- Partials 2792 2797 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhangchiqing
approved these changes
Apr 8, 2022
janezpodhostnik
pushed a commit
that referenced
this pull request
Apr 21, 2022
…g to hundreds of GB (#2281) * Drop checkpoint files from OS file cache After reading or creating a checkpoint file, drop it from the OS file cache. This change helps prevent Grafana EN Memory Usage chart from showing hundreds of GB as used because it doesn't exclude the OS file cache. Without this change, checkpointing will add over 100GB to OS file cache each time because each checkpoint file is over 50GB. If GOOS != linux then do nothing. * Update ledger/complete/wal/checkpointer.go Co-authored-by: Leo Zhang <zhangchiqing@gmail.com> * Log command to drop file from OS file cache * Update comment for requestDropFromOSFileCache * Fix lint error * Fix lint error Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #2280 into v0.25
NOTE: the CI Lint error also occurs in prior backports to v0.25 and can be ignored.