Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap From Snapshot Pt. 3: Test Coverage #374

Merged
merged 35 commits into from
Feb 25, 2021
Merged

Bootstrap From Snapshot Pt. 3: Test Coverage #374

merged 35 commits into from
Feb 25, 2021

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Feb 5, 2021 •
edited
Loading

Ticket: https://github.com/dapperlabs/flow-go/issues/4890

This is part 3 of supporting bootstrapping from an arbitrary protocol state snapshot (following from #272 and #312).

Changes

  • Add tests for bootstrapping the protocol state from non-root snapshots
  • Change Snapshot interface to combine seal/result query to SealedResult Bootstrap from Snapshot Pt. 2 #312 (comment)
  • Split Bootstrap function into helper functions
  • Fix a bug in inmem.Snapshot#Clustering where it would not return clustering for set-up but un-committed epochs
  • Update various test utilities and tests that made assumptions broken by bootstrapping changes
  • Change PayloadFixture:
    • Return literal rather than pointer to match block/header fixtures and so it can be used directly in SetPayload
    • Use an empty payload by default and add contents as needed. An empty payload works fine for most applications. For cases where we needed the payload to have a particular to have a particular form, it has been updated to explicitly specify that when generating the fixture (eg. PayloadFixture(WithSeals(...))).

@jordanschalm jordanschalm mentioned this pull request Feb 5, 2021
Merged
@jordanschalm jordanschalm changed the title Bootstrap From Snapshot Pt. 3: The Bootstrappening Bootstrap From Snapshot Pt. 3: Test Coverage Feb 5, 2021
@jordanschalm jordanschalm reopened this Feb 6, 2021
@jordanschalm jordanschalm changed the base branch from feature/serializable-snapshots to jordan/4890-bootstrap-pt2 February 6, 2021 00:07
@jordanschalm jordanschalm mentioned this pull request Feb 8, 2021
Merged
Base automatically changed from jordan/4890-bootstrap-pt2 to feature/serializable-snapshots February 8, 2021 17:03
@jordanschalm
consolidate Latest seal and result in protocol.Snapshot
a0ee6dc
@jordanschalm
update to SealedResult in Snapshot implementations
f26d672
@jordanschalm
update snapshot mock
21e0956
@jordanschalm
use new SealedResult API
795ced5
@jordanschalm
SealedResult tests
59a4822
@jordanschalm
check root snapshot qc block ID
182a079
@jordanschalm
use correct random source in bootstrap/testnet
ddb5344
@jordanschalm
include receipts in sealing segment test
0109fc0
@jordanschalm
move bootstrap tests to state_test
d081fdd
@jordanschalm
begin adding non-root bootstrapping
b51930d
@jordanschalm
fix bootstrapping
cdd40c2 
use head when indexing latest seal
use head as root block - necessary because the qc included in a snapshot
is for the root block -- but may need re-thinking because now we have
blocks in storage below the root block
@jordanschalm
Merge branch 'feature/serializable-snapshots' into jordan/4890-pt3
812ce6f
@jordanschalm
generate clusters based on final participants
c9322ca
@jordanschalm
bootstrapping tests
34b4e2f
@jordanschalm
fix bug with converting clustering in setup epochs
ddaa844
@jordanschalm
fix access/ingestion tests
8f4fe26 
these tests assumed block fixtures always contained guarantees --
updated to explicitly add them each time
@jordanschalm
fix payload test to compare literal
bccdd6d
@jordanschalm jordanschalm marked this pull request as ready for review February 10, 2021 02:23
zhangchiqing
zhangchiqing approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

state/protocol/badger/state_test.go Outdated Show resolved Hide resolved
state/protocol/badger/state_test.go Outdated Show resolved Hide resolved
AlexHentschel
AlexHentschel approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jordanschalm @zhangchiqing
Apply suggestions from code review
d3c2af2 
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
@jordanschalm jordanschalm merged commit fb13096 into feature/serializable-snapshots Feb 25, 2021
@jordanschalm jordanschalm deleted the jordan/4890-pt3 branch February 25, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexHentschel AlexHentschel AlexHentschel approved these changes

@zhangchiqing zhangchiqing zhangchiqing approved these changes

@durkmurder durkmurder Awaiting requested review from durkmurder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jordanschalm @zhangchiqing @AlexHentschel