Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RegisterIDToKey & RegisterValuesToValues from execution state #3821

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

pattyshack
Copy link
Contributor

they've been replaced by RegisterEntriesToKeysValues

they've been replaced by RegisterEntriesToKeysValues
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #3821 (c6723d9) into master (99337f3) will decrease coverage by 4.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
- Coverage   54.71%   50.70%   -4.01%     
==========================================
  Files         691      644      -47     
  Lines       65377    56421    -8956     
==========================================
- Hits        35768    28611    -7157     
+ Misses      26680    25477    -1203     
+ Partials     2929     2333     -596     
Flag Coverage Δ
unittests 50.70% <ø> (-4.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ratelimit/internal/limiter_map/rate_limiter_map.go 76.00% <0.00%> (-2.67%) ⬇️
fvm/transactionVerifier.go 81.12% <0.00%> (-1.21%) ⬇️
engine/execution/state/state.go
engine/access/rest/request/create_transaction.go
engine/common/splitter/engine.go
engine/consensus/compliance/engine.go
engine/execution/ingestion/engine.go
...ine/verification/fetcher/chunkconsumer/consumer.go
engine/access/rest/network.go
engine/execution/messages.go
... and 253 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 99337f3

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

@pattyshack
Copy link
Contributor Author

bors merge

@bors bors bot merged commit b0f6598 into master Jan 17, 2023
@bors bors bot deleted the patrick/clean-up-register-to-ledger-convert-funcs branch January 17, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants