Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v0.39.2 #4434

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

turbolent
Copy link
Member

Description

Automatically update to:

@turbolent turbolent requested review from a team June 6, 2023 21:27
@turbolent
Copy link
Member Author

bors merge

@turbolent turbolent changed the title Auto update to onflow/cadence v0.39.2 Update to Cadence v0.39.2 Jun 6, 2023
bors bot added a commit that referenced this pull request Jun 6, 2023
4434: Auto update to onflow/cadence v0.39.2 r=turbolent a=turbolent


## Description

Automatically update to:
- [onflow/flow-go-sdk v0.41.1](https://github.com/onflow/flow-go-sdk/releases/tag/v0.41.1)
- [onflow/cadence v0.39.2](https://github.com/onflow/cadence/releases/tag/v0.39.2)



Co-authored-by: Bastian Müller <bastian@axiomzen.co>
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #4434 (86772e8) into master (bd75bf9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4434   +/-   ##
=======================================
  Coverage   53.70%   53.71%           
=======================================
  Files         888      888           
  Lines       82612    82612           
=======================================
+ Hits        44370    44371    +1     
  Misses      34749    34749           
+ Partials     3493     3492    -1     
Flag Coverage Δ
unittests 53.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit bd75bf9

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-231.5ms ± 2%30.7ms ± 3%~(p=0.065 n=6+6)
RuntimeTransaction/convert_int_to_string-232.9ms ± 4%32.9ms ± 3%~(p=1.000 n=6+6)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-233.8ms ± 2%35.8ms ±14%~(p=0.366 n=6+7)
RuntimeTransaction/get_signer_address-231.6ms ± 1%31.7ms ± 3%~(p=0.699 n=6+6)
RuntimeTransaction/get_public_account-234.8ms ± 5%34.0ms ± 4%~(p=0.181 n=7+6)
RuntimeTransaction/get_account_and_get_balance-2263ms ± 9%257ms ± 2%~(p=0.534 n=6+7)
RuntimeTransaction/get_account_and_get_available_balance-2250ms ± 2%251ms ± 1%~(p=0.836 n=6+7)
RuntimeTransaction/get_account_and_get_storage_used-237.1ms ± 3%36.7ms ± 2%~(p=0.534 n=7+6)
RuntimeTransaction/get_account_and_get_storage_capacity-2224ms ± 2%223ms ± 3%~(p=0.534 n=6+7)
RuntimeTransaction/get_signer_vault-239.2ms ± 5%38.8ms ± 5%~(p=0.710 n=7+7)
RuntimeTransaction/get_signer_receiver-249.7ms ± 3%49.0ms ± 3%~(p=0.295 n=7+6)
RuntimeTransaction/transfer_tokens-2205ms ± 2%204ms ± 3%~(p=0.731 n=6+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-238.9ms ± 5%38.4ms ± 9%~(p=0.318 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-283.3ms ± 2%83.6ms ± 3%~(p=0.902 n=7+7)
RuntimeTransaction/create_new_account-2861ms ± 1%866ms ± 2%~(p=0.383 n=7+7)
RuntimeTransaction/call_empty_contract_function-234.3ms ± 1%34.5ms ± 2%~(p=1.000 n=5+7)
RuntimeTransaction/emit_event-249.4ms ± 6%48.6ms ± 6%~(p=0.456 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2137ms ± 2%135ms ± 2%~(p=0.053 n=7+7)
RuntimeTransaction/copy_array_from_storage-2135ms ± 3%135ms ± 2%~(p=0.456 n=7+7)
RuntimeNFTBatchTransfer-2126ms ± 4%125ms ± 3%~(p=0.535 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-24.62s ± 1%4.59s ± 1%~(p=0.128 n=7+7)
 
computationdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2502 ± 0%502 ± 0%~(all equal)
RuntimeTransaction/get_signer_address-2302 ± 0%302 ± 0%~(all equal)
RuntimeTransaction/get_public_account-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-21.00k ± 0%1.00k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-23.10k ± 0%3.10k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-21.70k ± 0%1.70k ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-23.50k ± 0%3.50k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/create_new_account-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/emit_event-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
 
interactionsdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_signer_address-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_public_account-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-246.4k ± 0%46.4k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-238.3k ± 0%38.3k ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-242.1k ± 0%42.1k ± 0%~(all equal)
RuntimeTransaction/create_new_account-284.3k ± 0%84.3k ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-238.3k ± 0%38.3k ± 0%~(all equal)
RuntimeTransaction/emit_event-238.3k ± 0%38.3k ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-243.4k ± 0%43.4k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-243.4k ± 0%43.4k ± 0%~(all equal)
 
alloc/opdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-235.1MB ± 3%34.8MB ± 4%~(p=0.535 n=7+7)
RuntimeTransaction/convert_int_to_string-235.4MB ± 3%35.9MB ± 2%~(p=0.073 n=6+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-235.8MB ± 6%35.7MB ± 3%~(p=0.710 n=7+7)
RuntimeTransaction/get_signer_address-235.7MB ± 4%35.4MB ± 3%~(p=0.535 n=7+7)
RuntimeTransaction/get_public_account-237.1MB ± 3%36.5MB ± 2%~(p=0.138 n=7+6)
RuntimeTransaction/get_account_and_get_balance-2122MB ± 2%122MB ± 3%~(p=1.000 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2107MB ± 4%107MB ± 2%~(p=0.710 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-236.8MB ± 5%36.6MB ± 3%~(p=0.710 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2104MB ± 3%104MB ± 3%~(p=0.902 n=7+7)
RuntimeTransaction/get_signer_vault-237.2MB ± 4%37.3MB ± 4%~(p=0.805 n=7+7)
RuntimeTransaction/get_signer_receiver-240.9MB ± 5%40.3MB ± 6%~(p=0.456 n=7+7)
RuntimeTransaction/transfer_tokens-284.8MB ± 2%84.0MB ± 3%~(p=0.165 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-236.6MB ± 5%35.9MB ± 4%~(p=0.209 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-254.3MB ± 3%54.4MB ± 3%~(p=1.000 n=7+7)
RuntimeTransaction/create_new_account-2184MB ± 1%185MB ± 1%~(p=0.710 n=7+7)
RuntimeTransaction/call_empty_contract_function-236.3MB ± 3%35.7MB ± 1%~(p=0.082 n=6+5)
RuntimeTransaction/emit_event-241.2MB ± 8%40.7MB ± 5%~(p=0.710 n=7+7)
RuntimeTransaction/borrow_array_from_storage-268.3MB ± 3%68.4MB ± 4%~(p=0.805 n=7+7)
RuntimeTransaction/copy_array_from_storage-281.6MB ± 2%81.7MB ± 2%~(p=0.535 n=7+7)
RuntimeNFTBatchTransfer-256.1MB ± 2%56.3MB ± 6%~(p=0.805 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-21.24GB ± 0%1.24GB ± 1%~(p=0.456 n=7+7)
 
allocs/opdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/transfer_tokens-2866k ± 0%866k ± 0%+0.01%(p=0.031 n=7+6)
RuntimeTransaction/reference_tx-284.4k ± 0%84.4k ± 0%~(p=0.558 n=7+7)
RuntimeTransaction/convert_int_to_string-296.6k ± 0%96.6k ± 0%~(p=0.188 n=6+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2108k ± 0%108k ± 0%~(p=0.303 n=7+7)
RuntimeTransaction/get_signer_address-288.6k ± 0%88.6k ± 0%~(p=0.719 n=6+7)
RuntimeTransaction/get_public_account-2113k ± 0%113k ± 0%~(p=0.090 n=7+7)
RuntimeTransaction/get_account_and_get_balance-21.32M ± 0%1.32M ± 0%~(p=0.128 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-21.27M ± 0%1.27M ± 0%~(p=0.710 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2124k ± 0%124k ± 0%~(p=0.597 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-21.14M ± 0%1.14M ± 0%~(p=0.333 n=7+7)
RuntimeTransaction/get_signer_vault-2129k ± 0%129k ± 0%~(p=0.730 n=7+7)
RuntimeTransaction/get_signer_receiver-2215k ± 0%215k ± 0%~(p=0.978 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2135k ± 0%135k ± 0%~(p=0.550 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2218k ± 0%218k ± 0%~(p=0.535 n=7+7)
RuntimeTransaction/create_new_account-22.35M ± 0%2.35M ± 0%~(p=0.435 n=7+7)
RuntimeTransaction/call_empty_contract_function-2102k ± 0%102k ± 0%~(p=0.731 n=7+7)
RuntimeTransaction/emit_event-2139k ± 0%139k ± 0%~(p=0.871 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2364k ± 0%364k ± 0%~(p=0.367 n=7+7)
RuntimeTransaction/copy_array_from_storage-2296k ± 0%296k ± 0%~(p=0.073 n=7+7)
RuntimeNFTBatchTransfer-2276k ± 1%276k ± 1%~(p=0.620 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-217.7M ± 0%17.7M ± 0%~(p=0.383 n=7+7)
 
us/txdelta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-22.26k ± 1%2.24k ± 0%~(p=0.103 n=7+7)
 

@bors
Copy link
Contributor

bors bot commented Jun 6, 2023

@turbolent
Copy link
Member Author

bors retry

@bors bors bot merged commit 189f62e into master Jun 6, 2023
@bors bors bot deleted the auto-update-onflow-cadence-v0.39.2 branch June 6, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants