port - [Exec] Use CCF in self-describing mode to encode events (replaces JSON-CDC) #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses CCF in fully self-describing mode, so events will encode to about 1/2 the size of JSON-CDC encoding. Using CCF in partially self-describing mode can encode events to 1/14 the size of JSON-CDC but that requires other changes outside of CCF codec.
Since JSON-CDC encodes less type information than CCF, decoding JSON-CDC and then encoding it in CCF breaks because required type information is missing. Fix this by creating Cadence events and then encoding it in CCF, without involving JSON-CDC.
Currently, JSON-CDC decoded event fields are not explicitly sorted and field values are obtained by index in some tests. This isn't compatible with CCF which explicitly sorts fields for determinism. Fix fvm tests by obtaining field values by field identifier to avoid dependency on field order.
Currently, JSON-CDC decoded event fields are not explicitly sorted and field values are obtained by index in some tests. This isn't compatible with CCF which explicitly sorts fields for determinism. Fix fvm tests by obtaining field values by field identifier to avoid dependency on field order.
Currently, JSON-CDC decoded event fields are not explicitly sorted and field values are obtained by index in some tests. This isn't compatible with CCF which explicitly sorts fields for determinism. Fix service events by obtaining field values by field identifier to avoid dependency on field order.
This update gets Cadence PRs 2528 and 2529 to unblock tests.
janezpodhostnik
force-pushed
the
janez/port-4417
branch
from
4841f4e to
53d75c1
Compare
FVM Benchstat comparisonThis branch with compared with the base branch onflow:v0.31 commit d988ba2 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
janezpodhostnik
force-pushed
the
janez/port-4417
branch
from
53d75c1 to
1b552de
Compare
…w-go into janez/port-4417
janezpodhostnik
force-pushed
the
janez/port-4417
branch
from
8b2cf6e to
788dcb0
Compare
Codecov Report
@@ Coverage Diff @@
## v0.31 #4437 +/- ##
==========================================
+ Coverage 53.67% 54.15% +0.47%
==========================================
Files 887 887
Lines 82528 83653 +1125
==========================================
+ Hits 44296 45301 +1005
- Misses 34748 34834 +86
- Partials 3484 3518 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fxamacker
approved these changes
Jun 7, 2023
koko1123
approved these changes
Jun 7, 2023
koko1123
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this contains #4439 that should be merged first
this is a port of #4417.
I checked everything file by file and they are all identical besides go.mod-s and go.sum-s