-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Change Contract Code Migration #5191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'll see which contracts need to be updated and add them. This will need to support all networks
cmd/util/ledger/migrations/change_contract_code_migration_test.go
Outdated
Show resolved
Hide resolved
I guess we can use Currently it returns:
Are all of them deployed at bootstrapping time and need to be updated by the migration? Are there any other contracts that need to be updated using this migration? |
More contracts that I can think of that might be worth upgrading as part of this migration: Tokens: These are all pretty important, but none of them are critical for core network operation as far as I know, so I'm not sure if they all need to belong in this migration, but I could probably make arguments for most of them. |
@joshuahannan Thanks! Can you please review e7e4a4f and check the values are correct (addresses, imports, code)? It adds |
Looks good to me! We'll be starting on the other contracts soon |
@janezpodhostnik Can you please have a look at my changes? (cannot request a review from you, as you opened the PR) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5191 +/- ##
==========================================
+ Coverage 55.99% 56.21% +0.21%
==========================================
Files 649 995 +346
Lines 63379 95260 +31881
==========================================
+ Hits 35492 53551 +18059
- Misses 25321 37728 +12407
- Partials 2566 3981 +1415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good besides one comment.
ref: onflow/cadence#2989