Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates contract dependencies and state commitments #5301

Merged
merged 5 commits into from
Jan 26, 2024

Conversation

joshuahannan
Copy link
Member

No description provided.

@joshuahannan joshuahannan requested review from turbolent and SupunS and removed request for ramtinms, yhassanzadeh13 and janezpodhostnik January 25, 2024 22:23
Base automatically changed from bastian/stable-cadence-update to feature/stable-cadence January 25, 2024 23:13
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8af35c0) 58.45% compared to head (0c15a2b) 60.61%.

Files Patch % Lines
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5301      +/-   ##
==========================================================
+ Coverage                   58.45%   60.61%   +2.15%     
==========================================================
  Files                         911      742     -169     
  Lines                       86472    71488   -14984     
==========================================================
- Hits                        50547    43330    -7217     
+ Misses                      32208    24949    -7259     
+ Partials                     3717     3209     -508     
Flag Coverage Δ
unittests 60.61% <0.00%> (+2.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member

trying to fix CI

@turbolent turbolent closed this Jan 26, 2024
@turbolent turbolent reopened this Jan 26, 2024
@turbolent turbolent merged commit 197132c into feature/stable-cadence Jan 26, 2024
96 of 102 checks passed
@turbolent turbolent deleted the josh/stable-cadence-update branch January 26, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants