Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cadence 1.0] Make staged contract code update migration aware of updated system contracts #5461

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 27, 2024

Work towards onflow/cadence#3096

@turbolent turbolent requested a review from a team February 27, 2024 00:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.77%. Comparing base (b9c9109) to head (7e8777d).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/stable-cadence    #5461       +/-   ##
===========================================================
- Coverage                   56.39%   45.77%   -10.62%     
===========================================================
  Files                        1032      168      -864     
  Lines                      100711    17081    -83630     
===========================================================
- Hits                        56796     7819    -48977     
+ Misses                      39605     8581    -31024     
+ Partials                     4310      681     -3629     
Flag Coverage Δ
unittests 45.77% <ø> (-10.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the system-contract migration runs before the staged-contract migration, aren't the updated system-contracts available from the state?

@turbolent
Copy link
Member Author

Ah, it might be that this isn't necessary anymore. I ran into it initially, but the migration pipeline changed quite a bit since then

@turbolent turbolent closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants