Merge feature/protocol-state-kvstore to master
#5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jordan Schalm <jordan@dapperlabs.com>
* begin adding kvstore types * wip * sketching out versioned encoding * re-organize models and interfaces * update docs, tests * correct pointer in encoding test * lint: goimports * Update state/protocol/protocol_state/kvstore/interfaces.go Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co> --------- Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
Co-authored-by: Alexander Hentschel <alex.hentschel@axiomzen.co>
…flow-go into yurii/5292-storage-layer
Change to encode/decode passes tests, still requires cleanup: - adds encode/decode for new event type - adds tests for new event type - changes how decoding is implemented to prevent a bug. Previously we would re-encode, then re-decode the entire service event, after first decoding it into a weakly typed map. In particular with JSON, this could cause the data to change between encode/decode cycles, I think because of numeric type sizes.
- renamed methods, duplicated functions...
jordanschalm
requested review from
peterargue,
zhangchiqing,
ramtinms,
janezpodhostnik,
AlexHentschel and
durkmurder
as code owners
peterargue
approved these changes
May 3, 2024
turbolent
reviewed
May 3, 2024
AlexHentschel
approved these changes
May 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the
Protocol State KV Storefeature branch tomaster.There were many conflicts reported by Git. The vast majority were changes on
masterthat had no conflicting change on the feature branch. There were some conflicts in integration test suite (some changed method names and re-organization) and in tools and API methods for retrieving a protocol snapshot.The full list of conflicting files is in the description of the merge commit: 81b938e.
Changes made after the merge commit are in this diff
Outstanding TODOs
core-contractsdependency Mergefeature/protocol-state-kvstoretomaster#5840 (comment)