Enable service events for all collection context #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5845 +/- ##
==========================================
- Coverage 55.66% 55.64% -0.02%
==========================================
Files 1134 1134
Lines 89667 89661 -6
==========================================
- Hits 49910 49891 -19
- Misses 34965 34976 +11
- Partials 4792 4794 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
approved these changes
May 9, 2024
kc1116
approved these changes
May 9, 2024
AlexHentschel
approved these changes
May 9, 2024
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
jordanschalm
commented
May 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables service event collection for all transactions (not just the system chunk). See #5828 for reasoning.
I tested the change against onflow/flow-core-contracts#419 in f5e878b with this CI run. This runs the integration test network using a version of
NodeVersionBeaconwhich emits a service event outside the system chunk, then validates the service event is incorporated and processed by the protocol state. We aren't ready to deploy that smart contract change, so I reverted the commit which pins the necessary smart contract change to re-enable the test after running the test.TestProtocolVersionUpgradetest (validated in f5e878b with this CI run)