Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse static type cache across migrations in different accounts #5847

Merged
merged 1 commit into from
May 6, 2024

Conversation

dsainati1
Copy link
Contributor

@dsainati1 dsainati1 commented May 6, 2024

Work towards onflow/cadence#3297

Reuse the cache added in onflow/cadence#3232 across different accounts in the entitlements migration

@dsainati1 dsainati1 self-assigned this May 6, 2024
@dsainati1 dsainati1 changed the title reuse cache Reuse static type cache across migrations in different accounts May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.74%. Comparing base (41286b3) to head (3df860d).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5847      +/-   ##
==========================================================
+ Coverage                   55.81%   57.74%   +1.93%     
==========================================================
  Files                        1118      801     -317     
  Lines                       88515    65534   -22981     
==========================================================
- Hits                        49405    37844   -11561     
+ Misses                      34362    23881   -10481     
+ Partials                     4748     3809     -939     
Flag Coverage Δ
unittests 57.74% <100.00%> (+1.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsainati1 dsainati1 merged commit 4ff5c23 into feature/stable-cadence May 6, 2024
54 of 55 checks passed
@dsainati1 dsainati1 deleted the sainati/reuse-static-type-cache branch May 6, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants