Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] EVMAddress de/serialization follow up #5932

Merged
merged 6 commits into from
May 16, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented May 15, 2024

Related: #5422
Follow up on #5892

Including suggestions from @turbolent in the original PR

@sisyphusSmiling sisyphusSmiling requested a review from turbolent May 15, 2024 23:55
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review May 15, 2024 23:58
@sisyphusSmiling sisyphusSmiling self-assigned this May 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.62%. Comparing base (e206053) to head (0539f71).

Files Patch % Lines
utils/unittest/execution_state.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5932   +/-   ##
=======================================
  Coverage   55.61%   55.62%           
=======================================
  Files        1128     1128           
  Lines       88939    88939           
=======================================
+ Hits        49464    49469    +5     
+ Misses      34762    34761    -1     
+ Partials     4713     4709    -4     
Flag Coverage Δ
unittests 55.62% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sisyphusSmiling sisyphusSmiling added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit fc3e499 May 16, 2024
55 checks passed
@sisyphusSmiling sisyphusSmiling deleted the giovanni/evm-address-serialization branch May 16, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants