Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "v0.33 enable get block fix" #5940

Merged
merged 1 commit into from
May 17, 2024

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented May 16, 2024

Reverts #5896, because there is no HCU mainnet to deploy this, however, it's been deployed to devnet.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.83%. Comparing base (5fd8467) to head (160d48c).
Report is 16 commits behind head on v0.33.

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.33    #5940      +/-   ##
==========================================
+ Coverage   55.94%   59.83%   +3.88%     
==========================================
  Files         353       14     -339     
  Lines       31192      824   -30368     
==========================================
- Hits        17451      493   -16958     
+ Misses      12355      309   -12046     
+ Partials     1386       22    -1364     
Flag Coverage Δ
unittests 59.83% <ø> (+3.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1010001 j1010001 requested a review from a team May 17, 2024 03:42
@zhangchiqing zhangchiqing merged commit e31cf85 into v0.33 May 17, 2024
50 of 51 checks passed
@zhangchiqing zhangchiqing deleted the revert-5896-leo/v0.33-enable-get-block-fix branch May 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants