-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Reduce logging for script executions #5959
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5959 +/- ##
==========================================
+ Coverage 55.81% 55.83% +0.01%
==========================================
Files 1129 1129
Lines 89205 89210 +5
==========================================
+ Hits 49794 49808 +14
+ Misses 34656 34643 -13
- Partials 4755 4759 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
if err != nil { | ||
return err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a part of your diff, but we should move this up to immediately after the error is returned, on line 246.
@@ -318,6 +320,9 @@ func isInvalidArgumentError(scriptExecutionErr error) bool { | |||
|
|||
// shouldLogScript checks if the script hash is unique in the time window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// shouldLogScript checks if the script hash is unique in the time window | |
// shouldLogScript checks whether we should log a script, based on whether we have seen it recently | |
// and the current log level. |
This PR reduces logging related to script execution on Access nodes by making the following changes:
Debug
level