[Access] Stop Control feature for AN #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

peterargue merged 42 commits into onflow:master from The-K-R-O-K:AndriiSlisarchuk/5790-add-stop-control

Sep 12, 2024

Contributor

Guitarheroua commented Jul 11, 2024

Implemented stop control feature for Access Node

Guitarheroua added 5 commits

July 10, 2024 13:26


          Added stop control

f5f08a5


          Merge branch 'AndriiSlisarchuk/5788-version-control-module' of github…

b623d37

….com:The-K-R-O-K/flow-go into AndriiSlisarchuk/5790-add-stop-control


          Merge branch 'AndriiSlisarchuk/5788-version-control-module' of github…

ec68927

….com:The-K-R-O-K/flow-go into AndriiSlisarchuk/5790-add-stop-control


          Merge branch 'AndriiSlisarchuk/5788-version-control-module' of github…

7c5cd9b

….com:The-K-R-O-K/flow-go into AndriiSlisarchuk/5790-add-stop-control


          Finished with adding stop control module

837aeed

codecov-commenter commented Jul 11, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 45.19231% with 57 lines in your changes missing coverage. Please review.

Project coverage is 41.46%. Comparing base (72ac1d1) to head (2b4d7d0).

Files with missing lines	Patch %	Lines
cmd/access/node_builder/access_node_builder.go	0.00%	21 Missing ⚠️
cmd/observer/node_builder/observer_builder.go	0.00%	21 Missing ⚠️
...tasync/execution_data/processed_height_recorder.go	0.00%	8 Missing ⚠️
engine/common/stop/stop_control.go	90.38%	4 Missing and 1 partial ⚠️
...xecutiondatasync/execution_data/mock/downloader.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #6202    +/-   ##
========================================
  Coverage   41.45%   41.46%            
========================================
  Files        2022     2023     +1     
  Lines      144225   144329   +104     
========================================
+ Hits        59784    59841    +57     
- Misses      78248    78292    +44     
- Partials     6193     6196     +3

Flag	Coverage Δ
unittests	`41.46% <45.19%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

5f1543f

Guitarheroua requested a review from peterargue

July 18, 2024 15:25

peterargue reviewed

View reviewed changes

engine/access/ingestion/engine.go Outdated Show resolved Hide resolved

cmd/access/node_builder/access_node_builder.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

Guitarheroua added 5 commits

July 29, 2024 10:05


          Merge branch 'master' of github.com:The-K-R-O-K/flow-go into AndriiSl…

8a38169

…isarchuk/5790-add-stop-control


          Fixed remarks

89af759


          Merge branch 'master' of github.com:The-K-R-O-K/flow-go into AndriiSl…

d91fa14

…isarchuk/5790-add-stop-control


          Added index consumer

aee0542


          Added exe data sync cheks

9ca056c

Guitarheroua requested a review from peterargue

August 6, 2024 11:43

peterargue reviewed

View reviewed changes

Contributor

peterargue left a comment

added a few comments. I think we should also add this to the observer.

cmd/access/node_builder/access_node_builder.go Outdated Show resolved Hide resolved

cmd/access/node_builder/access_node_builder.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

peterargue reviewed

View reviewed changes

Contributor

peterargue left a comment

added a few comments. I think we should also add this to the observer.

Guitarheroua and others added 4 commits

August 8, 2024 16:03


          Added notifier to processed height recorder

b5eecb8


          Fixed remarks

a935e49


          Added stop control to observer node

477eca1


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

347e13e

Guitarheroua marked this pull request as ready for review

August 12, 2024 06:58

Guitarheroua requested review from peterargue and durkmurder

August 12, 2024 06:58

peterargue reviewed

View reviewed changes

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

module/executiondatasync/execution_data/processed_height_recorder.go Outdated Show resolved Hide resolved

module/executiondatasync/execution_data/processed_height_recorder.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

Guitarheroua and others added 3 commits

August 14, 2024 10:15


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control


          Fixed remarks

e0c2ae7


          Added tests

f572325

Guitarheroua requested a review from peterargue

August 14, 2024 21:20

peterargue reviewed

View reviewed changes

cmd/access/node_builder/access_node_builder.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control.go Outdated Show resolved Hide resolved

engine/common/stop/stop_control_test.go Outdated Show resolved Hide resolved

module/executiondatasync/execution_data/processed_height_recorder.go Show resolved Hide resolved

module/executiondatasync/execution_data/processed_height_recorder.go Outdated Show resolved Hide resolved


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

9649af1

peterargue requested review from janezpodhostnik and peterargue

August 28, 2024 15:49


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

235011b

peterargue reviewed

View reviewed changes

cmd/access/node_builder/access_node_builder.go Outdated Show resolved Hide resolved

Guitarheroua self-assigned this

Guitarheroua and others added 7 commits

August 29, 2024 14:04


          added dep component

b189df8


          Merge branch 'master' of github.com:The-K-R-O-K/flow-go into AndriiSl…

dbd0714

…isarchuk/5790-add-stop-control


          Merge branch 'master' of github.com:The-K-R-O-K/flow-go into AndriiSl…

b478786

…isarchuk/5790-add-stop-control


          Added checks for stop control enabled

123068f


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

91b9d3d


          Fixed tests

fa9d8b1


          Merge branch 'AndriiSlisarchuk/5790-add-stop-control' of github.com:T…

f2f2f60

…he-K-R-O-K/flow-go into AndriiSlisarchuk/5790-add-stop-control

janezpodhostnik reviewed

View reviewed changes

engine/common/stop/stop_control.go Show resolved Hide resolved

Guitarheroua and others added 2 commits

September 10, 2024 13:05


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

6dfdd63


          Fixed remark with deadlock

721d248

Guitarheroua requested review from janezpodhostnik and peterargue

September 10, 2024 13:50

janezpodhostnik approved these changes

View reviewed changes


          Merge branch 'master' into AndriiSlisarchuk/5790-add-stop-control

2b4d7d0

peterargue approved these changes

View reviewed changes

peterargue added this pull request to the merge queue

github-merge-queue bot removed this pull request from the merge queue due to failed status checks

peterargue added this pull request to the merge queue

Merged via the queue into onflow:master with commit df5769f

55 checks passed

peterargue deleted the AndriiSlisarchuk/5790-add-stop-control branch

September 12, 2024 14:02

Guitarheroua mentioned this pull request

[Access] Identify all PRs that need to be backported to v0.37 #6458

Closed

Guitarheroua pushed a commit to The-K-R-O-K/flow-go that referenced this pull request


          Merge pull request onflow#6202 from The-K-R-O-K/AndriiSlisarchuk/5790…

049d753

…-add-stop-control

[Access] Stop Control feature for AN

Guitarheroua mentioned this pull request

[Access] Backport transaction insufficient balance #6549

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet