Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] Improve run script command #6244

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

turbolent
Copy link
Member

  • Improve logging
  • Read script before lengthy state loading

@turbolent turbolent requested review from a team July 23, 2024 02:11
@turbolent turbolent changed the title Improve run script [Util] Improve run script command Jul 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 41.38%. Comparing base (f9bd3bf) to head (c89697d).

Files Patch % Lines
cmd/util/cmd/run-script/cmd.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6244      +/-   ##
==========================================
- Coverage   41.39%   41.38%   -0.01%     
==========================================
  Files        1989     1989              
  Lines      141624   141628       +4     
==========================================
- Hits        58620    58608      -12     
- Misses      76886    76903      +17     
+ Partials     6118     6117       -1     
Flag Coverage Δ
unittests 41.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent enabled auto-merge July 23, 2024 02:57
@turbolent turbolent added this pull request to the merge queue Jul 23, 2024
Merged via the queue into master with commit 6ce4c85 Jul 23, 2024
55 checks passed
@turbolent turbolent deleted the bastian/improve-run-script branch July 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants