-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Add migration to add a key to all service accounts #6271
Open
janezpodhostnik
wants to merge
18
commits into
v0.37
Choose a base branch
from
janez/migration-mainnet-add-keys-to-core-contracts-2
base: v0.37
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DO NOT MERGE] Add migration to add a key to all service accounts #6271
janezpodhostnik
wants to merge
18
commits into
v0.37
from
janez/migration-mainnet-add-keys-to-core-contracts-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.37 #6271 +/- ##
==========================================
+ Coverage 41.46% 43.54% +2.07%
==========================================
Files 2016 1804 -212
Lines 143694 124265 -19429
==========================================
- Hits 59589 54115 -5474
+ Misses 77927 64551 -13376
+ Partials 6178 5599 -579
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
changed the title
Add migration to add a key to all service accounts
[DO NOT MERGE] Add migration to add a key to all service accounts
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do Not Merge
This is an extra migration that adds a public key to all service accounts. The intended usage is for testing the migration of mainnet. This allows us to run transactions on the test migrated mainnet network to setup networking addresses and epoch related state.
this is same as: #6096. I just accidentally closed that one, and I cannot reopen it