[Access] Add compatible range to Node Version Info endpoint #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6294 +/- ##
==========================================
- Coverage 41.47% 41.46% -0.01%
==========================================
Files 2017 2017
Lines 143768 143785 +17
==========================================
- Hits 59622 59619 -3
- Misses 77972 77990 +18
- Partials 6174 6176 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Guitarheroua
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Looks good for me!
Have a minor comment about the naming of the fields on https://github.com/onflow/flow PR, so the same goes here.
…of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6248-compatible-range-to-node-version
…ow, updated tests
…of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6248-compatible-range-to-node-version
…of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6248-compatible-range-to-node-version
…of github.com:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6248-compatible-range-to-node-version
peterargue
reviewed
Aug 16, 2024
…drukhiv/6248-compatible-range-to-node-version
peterargue
previously approved these changes
Aug 28, 2024
|
@UlyanaAndrukhiv looks good. Please fix conflicts, then I'll approve and merge |
peterargue
approved these changes
Aug 29, 2024
peterargue
deleted the
UlyanaAndrukhiv/6248-compatible-range-to-node-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6248
Related PRs:
Context
In this PR :
NodeVersionInfoendpoint was updated to return the first and last block that the node's version supports.