Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] improve debug tracing #6299

Merged
merged 9 commits into from
Aug 8, 2024
Merged

[Flow EVM] improve debug tracing #6299

merged 9 commits into from
Aug 8, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Aug 7, 2024

This PR improves tracing

  • by wrapping trace methods for panics if not nil (the geth code have nil checks)
  • will not re-create the wrapper in case of two calls to TxTracer
  • adds debug level logs for tracing
  • adds a test for the case that a contract is called through a proxy

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 32.03125% with 87 lines in your changes missing coverage. Please review.

Project coverage is 42.79%. Comparing base (29ec7b8) to head (762d8bb).

Files Patch % Lines
fvm/evm/debug/tracer.go 33.06% 75 Missing and 8 partials ⚠️
fvm/evm/testutils/contract.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6299      +/-   ##
==========================================
+ Coverage   39.46%   42.79%   +3.32%     
==========================================
  Files        1773     1758      -15     
  Lines      123185   119169    -4016     
==========================================
+ Hits        48616    50995    +2379     
+ Misses      69296    63062    -6234     
+ Partials     5273     5112     -161     
Flag Coverage Δ
unittests 42.79% <32.03%> (+3.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms changed the title Ramtin/evm patch tracer [Flow EVM] improve tracing Aug 7, 2024
@ramtinms ramtinms marked this pull request as ready for review August 7, 2024 05:18
@ramtinms ramtinms requested review from sideninja and turbolent August 7, 2024 05:18
@ramtinms ramtinms changed the title [Flow EVM] improve tracing [Flow EVM] improve debug tracing Aug 7, 2024
@j1010001 j1010001 requested a review from zhangchiqing August 7, 2024 15:50
@ramtinms ramtinms enabled auto-merge August 8, 2024 01:15
@ramtinms ramtinms added this pull request to the merge queue Aug 8, 2024
Merged via the queue into master with commit 1dd0921 Aug 8, 2024
55 checks passed
@ramtinms ramtinms deleted the ramtin/evm-patch-tracer branch August 8, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants