Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cadence 1.0 Migration] Fix migration of storage path capabilities #6306

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

turbolent
Copy link
Member

Depends on onflow/cadence#3511

@turbolent turbolent requested a review from SupunS August 8, 2024 20:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 15 lines in your changes missing coverage. Please review.

Project coverage is 41.89%. Comparing base (1dd0921) to head (97bc1d9).

Files Patch % Lines
cmd/util/ledger/migrations/cadence.go 85.39% 11 Missing and 2 partials ⚠️
...util/ledger/migrations/cadence_values_migration.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6306      +/-   ##
==========================================
+ Coverage   41.47%   41.89%   +0.41%     
==========================================
  Files        2009     1993      -16     
  Lines      143081   141459    -1622     
==========================================
- Hits        59338    59258      -80     
+ Misses      77562    76024    -1538     
+ Partials     6181     6177       -4     
Flag Coverage Δ
unittests 41.89% <86.36%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS marked this pull request as ready for review August 8, 2024 22:32
@SupunS SupunS force-pushed the bastian/fix-storage-cap-migration branch from 2e7a90c to 97bc1d9 Compare August 8, 2024 22:46
@turbolent turbolent requested a review from a team August 8, 2024 22:50
@turbolent
Copy link
Member Author

Test and reporting look good 👍

@SupunS SupunS enabled auto-merge August 8, 2024 23:03
@SupunS SupunS added this pull request to the merge queue Aug 8, 2024
Merged via the queue into master with commit f4e316a Aug 9, 2024
55 checks passed
@SupunS SupunS deleted the bastian/fix-storage-cap-migration branch August 9, 2024 00:23
@turbolent turbolent changed the title Fix migration of storage path capabilities [Cadence 1.0 Migration] Fix migration of storage path capabilities Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants