[EVM] Offchain package - part 3 #6546
Conversation
| if err != nil { | ||
| return err | ||
| } | ||
| return baseView.Commit() |
There was a problem hiding this comment.
I must miss something here.
Does the Commit call persist the balance update into database?
If we want to override the balance for making a dry call, do we also need to revert the balance update after the dry call? Because otherwise, the dry call isn't "dry" since the database is updated, it will affect the next dry call. No?
There was a problem hiding this comment.
storage that is passed to the baseView is of type storage.EphemeralStorage. so all the changes would be discarded.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6546 +/- ##
==========================================
- Coverage 41.13% 41.12% -0.02%
==========================================
Files 2029 2031 +2
Lines 179324 179589 +265
==========================================
+ Hits 73765 73856 +91
- Misses 99366 99525 +159
- Partials 6193 6208 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
depends on #6545
Context:
the Offchain package allows off-chain software like (GW) to follow the EVM chain and be able to replay all transactions. It also facilitates running queries (e.g. eth_Call), making the complex internal details hidden from the user.
This PR provides the query functionality that can be used to query account meta (e.g. Balance, ...) and make eth_call supporting passing optional tracer and overriding values.