[EVM] Make chain config concurrency safe #6578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
commented
Oct 18, 2024
Comment on lines
+13
to
+16
|
|
||
| FlowEVMPreviewNetChainIDInUInt64 = FlowEVMPreviewNetChainID.Uint64() | ||
| FlowEVMTestNetChainIDInUInt64 = FlowEVMTestNetChainID.Uint64() | ||
| FlowEVMMainNetChainIDInUInt64 = FlowEVMMainNetChainID.Uint64() |
There was a problem hiding this comment.
conversion to uuid is not cheap, so I made it global vars to also save computation per evm tx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6578 +/- ##
=======================================
Coverage 41.15% 41.16%
=======================================
Files 2020 2020
Lines 178778 178808 +30
=======================================
+ Hits 73575 73602 +27
- Misses 99043 99048 +5
+ Partials 6160 6158 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Oct 18, 2024
janezpodhostnik
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this for the on-chain and live operations but for concurrent use of the emulator we need it (e.g. GW nodes)
Since these chain configs are read-only during execution and identical when on specific chain, I created a global instances to be reused to reduce memory allocation.