-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random beacon comments #6590
Open
tarakby
wants to merge
4
commits into
feature/efm-recovery
Choose a base branch
from
tarak/minor-suggestions
base: feature/efm-recovery
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Random beacon comments #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #6590 +/- ##
========================================================
- Coverage 42.10% 41.71% -0.40%
========================================================
Files 2012 2028 +16
Lines 178121 180208 +2087
========================================================
+ Hits 74994 75169 +175
- Misses 96944 98845 +1901
- Partials 6183 6194 +11
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
tarakby
requested review from
AlexHentschel,
jordanschalm and
durkmurder
and removed request for
zhangchiqing,
AlexHentschel and
jordanschalm
October 23, 2024 20:43
jordanschalm
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the DKG/Random beacon related docs:
β
(the set of nodes able to participate in the random beacon) is a subset ofπ β© π
.|β|
is in the safe range.