Random beacon comments #6590
Merged
Random beacon comments #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #6590 +/- ##
========================================================
- Coverage 41.71% 41.71% -0.01%
========================================================
Files 2030 2030
Lines 180459 180459
========================================================
- Hits 75272 75271 -1
- Misses 98991 98995 +4
+ Partials 6196 6193 -3
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
tarakby
requested review from
AlexHentschel,
jordanschalm and
durkmurder
and removed request for
zhangchiqing,
AlexHentschel and
jordanschalm
jordanschalm
approved these changes
Oct 25, 2024
AlexHentschel
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thank you for the detailed revisions. Love it. So much better and more accurate. No objections. My suggestions are essentially only trying to extend your documentation here and there with additional context to explain why things are the way they are on a more intuitive level. Feel free to reject or modify any or all of my suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the DKG/Random beacon related docs:
β(the set of nodes able to participate in the random beacon) is a subset ofπ β© π.|β|is in the safe range.