Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random beacon comments #6590

Open
wants to merge 4 commits into
base: feature/efm-recovery
Choose a base branch
from

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Oct 23, 2024

Updates to the DKG/Random beacon related docs:

  • clarify that the set β„› (the set of nodes able to participate in the random beacon) is a subset of π’Ÿ ∩ π’ž.
  • clarify that the protocol software implements a sanity check but does not guarantee that |β„›| is in the safe range.
  • minor clarifications about the DKG results and indices

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.71%. Comparing base (af0c50c) to head (c74dd80).
Report is 12 commits behind head on feature/efm-recovery.

Files with missing lines Patch % Lines
cmd/bootstrap/run/qc.go 0.00% 1 Missing ⚠️
model/convert/service_event.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           feature/efm-recovery    #6590      +/-   ##
========================================================
- Coverage                 42.10%   41.71%   -0.40%     
========================================================
  Files                      2012     2028      +16     
  Lines                    178121   180208    +2087     
========================================================
+ Hits                      74994    75169     +175     
- Misses                    96944    98845    +1901     
- Partials                   6183     6194      +11     
Flag Coverage Ξ”
unittests 41.71% <50.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@tarakby tarakby marked this pull request as ready for review October 23, 2024 20:43
model/convert/service_event.go Outdated Show resolved Hide resolved
model/flow/dkg.go Outdated Show resolved Hide resolved
module/dkg.go Outdated Show resolved Hide resolved
module/dkg.go Outdated Show resolved Hide resolved
module/dkg/client.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants