[Access] Make REST message size limit configurable #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6596 +/- ##
=======================================
Coverage 41.19% 41.20%
=======================================
Files 2052 2052
Lines 182191 182209 +18
=======================================
+ Hits 75062 75080 +18
Misses 100839 100839
Partials 6290 6290
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Nov 1, 2024
peterargue
reviewed
Nov 4, 2024
| @@ -1508,6 +1513,10 @@ func (builder *FlowAccessNodeBuilder) extraFlags() { | |||
| return errors.New("execution-data-indexing-enabled must be set if check-payer-balance is enabled") | |||
| } | |||
|
|
|||
| if builder.rpcConf.RestConfig.MaxRequestSize <= 0 { | |||
| return errors.New("rest-max-request-size must be greater than or equal to 0") | |||
There was a problem hiding this comment.
Suggested change
| return errors.New("rest-max-request-size must be greater than or equal to 0") | |
| return errors.New("rest-max-request-size must be greater than 0") |
| @@ -851,6 +856,10 @@ func (builder *ObserverServiceBuilder) extraFlags() { | |||
| } | |||
| } | |||
|
|
|||
| if builder.rpcConf.RestConfig.MaxRequestSize <= 0 { | |||
| return errors.New("rest-max-request-size must be greater than or equal to 0") | |||
There was a problem hiding this comment.
Suggested change
| return errors.New("rest-max-request-size must be greater than or equal to 0") | |
| return errors.New("rest-max-request-size must be greater than 0") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6566