[Access] Change SendAndSubscribe endpoint's MessageIndex to start at 0 #6598
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6598 +/- ##
==========================================
- Coverage 41.19% 41.19% -0.01%
==========================================
Files 2052 2052
Lines 182191 182200 +9
==========================================
+ Hits 75062 75065 +3
+ Misses 100839 100838 -1
- Partials 6290 6297 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ex-start-with-zero
Guitarheroua
approved these changes
Oct 29, 2024
…-send-and-subscribe-endoints-msg-index-start-with-zero
…-zero' of github.com:AndriiDiachuk/flow-go into change-send-and-subscribe-endoints-msg-index-start-with-zero
…ex-start-with-zero
peterargue
reviewed
Nov 4, 2024
| @@ -381,7 +381,7 @@ func (h *Handler) handleEventsResponse(send sendSubscribeEventsResponseFunc, hea | |||
| return status.Errorf(codes.Internal, "could not convert events to entity: %v", err) | |||
| } | |||
|
|
|||
| index := messageIndex.Increment() | |||
| index := messageIndex.Value() | |||
There was a problem hiding this comment.
nit: keep the get and set together so the stream fails quickly if there's an issue
Suggested change
| index := messageIndex.Value() | |
| index := messageIndex.Value() | |
| if ok := messageIndex.Set(index + 1); !ok { | |
| return status.Errorf(codes.Internal, "message index already incremented to %d", messageIndex.Value()) | |
| } |
| @@ -495,7 +499,7 @@ func (h *Handler) handleAccountStatusesResponse( | |||
| return err | |||
| } | |||
|
|
|||
| index := messageIndex.Increment() | |||
| index := messageIndex.Value() | |||
| @@ -1435,15 +1435,19 @@ func (h *Handler) SendAndSubscribeTransactionStatuses( | |||
| messageIndex := counters.NewMonotonousCounter(0) | |||
| return subscription.HandleSubscription(sub, func(txResults []*TransactionResult) error { | |||
| for i := range txResults { | |||
| value := messageIndex.Increment() | |||
| index := messageIndex.Value() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6575
Related PR: onflow/flow#1520