[Storage] Pruning - add a test case to verify compaction can reclaim disk space #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
changed the title
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
from
b5cb99c
to
402c14d
Compare
zhangchiqing
force-pushed
the
leo/db-ops
branch
from
257bde0
to
bbfb3a1
Compare
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
from
402c14d
to
3e53a01
Compare
zhangchiqing
commented
Oct 30, 2024
Comment on lines
+207
to
+208
| require.Greater(t, sizeBefore, sizeAfter, | ||
| fmt.Sprintf("expected disk usage to be reduced after compaction, before: %d, after: %d", sizeBefore, sizeAfter)) |
There was a problem hiding this comment.
This verifies the disk usage will be reduced.
zhangchiqing
force-pushed
the
leo/db-ops
branch
5 times, most recently
from
77b44d1
to
17972e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review this PR first
Working towards #6516