[Storage] Pruning - add a test case to verify compaction can reclaim disk space #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
changed the title
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
from
b5cb99c to
402c14d
Compare
zhangchiqing
force-pushed
the
leo/db-ops
branch
from
257bde0 to
bbfb3a1
Compare
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
from
402c14d to
3e53a01
Compare
zhangchiqing
commented
Oct 30, 2024
Comment on lines
+207
to
+208
| require.Greater(t, sizeBefore, sizeAfter, | ||
| fmt.Sprintf("expected disk usage to be reduced after compaction, before: %d, after: %d", sizeBefore, sizeAfter)) |
There was a problem hiding this comment.
This verifies the disk usage will be reduced.
zhangchiqing
force-pushed
the
leo/db-ops
branch
5 times, most recently
from
77b44d1 to
17972e0
Compare
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
from
3e53a01 to
e25393f
Compare
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
2 times, most recently
from
207cd1a to
77fb95b
Compare
zhangchiqing
force-pushed
the
leo/db-ops-dbstore
branch
from
77fb95b to
5b15c09
Compare
zhangchiqing
requested review from
jordanschalm,
AlexHentschel,
durkmurder,
Kay-Zee and
tarakby
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6603 +/- ##
==========================================
- Coverage 41.18% 41.17% -0.02%
==========================================
Files 2109 2111 +2
Lines 185660 185733 +73
==========================================
+ Hits 76466 76467 +1
- Misses 102781 102852 +71
- Partials 6413 6414 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fxamacker
approved these changes
Jan 10, 2025
storage/operation/writes_test.go
Outdated
|
|
||
| // Trigger compaction | ||
| require.NoError(t, db.Compact(prefix, []byte{2}, true)) | ||
| wg.Wait() |
There was a problem hiding this comment.
Maybe use a timer here so the test doesn't stuck on wg.Wait() in case of error.
zhangchiqing
removed request for
Kay-Zee,
durkmurder,
AlexHentschel,
tarakby and
jordanschalm
janezpodhostnik
approved these changes
Jan 13, 2025
| require.NoError(t, db.Compact(prefix, []byte{2}, true)) | ||
|
|
||
| // Use a timer to implement a timeout for wg.Wait() | ||
| timeout := time.After(30 * time.Second) |
There was a problem hiding this comment.
this sounds like a long time... can we shorten the timer.
There was a problem hiding this comment.
Will adjust in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review this PR first
Working towards #6516