Re-enable test TestProtocolVersionUpgrade

[jordanschalm]

We implemented TestProtocolVersionUpgrade as part of the original work around the Protocol KVStore, but disabled it until the corresponding smart contract change was ready to deploy to Mainnet. That smart contract change is now merged to the core-contracts feature branch, onflow/flow-core-contracts#465, to be deployed alongside EFM Recovery.

TODO: Need to update state commitments

This PR re-enables the test.

• The smart contract implementation has been modified since this test was first written to emit the service event immediately (not in a system chunk)
• This PR enables require-approvals=1 and extends Chunk Data Model supports per-chunk service event mapping #6744, which implements a solution for verifying service events outside the system chunk.

[AlexHentschel]

Just came across this details while reviewing:

flow-go/state/protocol/protocol_state/kvstore/models.go

Lines 123 to 126 in a065619

	func (model *Modelv0) SetEpochExtensionViewCount(viewCount uint64) error {
	// Strictly speaking it should be perfectly fine to use a value viewCount >= model.FinalizationSafetyThreshold.
	// By using a sligtly higher value(factor of 2) we ensure that extension is big enough in practice to give operators a bigger
	// window in which a valid epoch recover event could be submitted.

technically, the operators don't submit the epoch recovery transaction - it is the human governance committee. Would you mind updating the documentation (including the typo in sligtly):

// Strictly speaking it should be perfectly fine to use a value viewCount >= model.FinalizationSafetyThreshold.
// By using a slightly higher value (factor of 2), we ensure that each extension spans a sufficiently big time 
// window for the human governance committee to submit a valid epoch recovery transaction. 

[AlexHentschel]

looks good.

[durkmurder]

🚢

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.67%. Comparing base (6c251a3) to head (74c9d8f).

Files with missing lines	Patch %	Lines
utils/unittest/execution_state.go	0.00%	2 Missing ⚠️
integration/utils/transactions.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                    @@
##           feature/efm-recovery    #6752      +/-   ##
========================================================
- Coverage                 41.69%   41.67%   -0.02%     
========================================================
  Files                      2033     2033              
  Lines                    180748   180749       +1     
========================================================
- Hits                      75359    75327      -32     
- Misses                    99190    99221      +31     
- Partials                   6199     6201       +2     

Flag	Coverage Δ
unittests	41.67% <40.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.