Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Implement inactivity tracker #6817

Draft
wants to merge 108 commits into
base: master
Choose a base branch
from

Conversation

UlyanaAndrukhiv
Copy link
Contributor

Closes: #6799

NOTE: this PR should be merged after #6798

Context

This PR implements an inactivity tracker for the WebSocket controller. It ensures that WebSocket connections are closed if there are no active subscriptions for a configured period of time.

AndriiDiachuk and others added 30 commits November 22, 2024 16:15
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…The-K-R-O-K/flow-go into AndriiDiachuk/6587-accounts-data-provider
…The-K-R-O-K/flow-go into AndriiDiachuk/6587-accounts-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
…:The-K-R-O-K/flow-go into AndriiDiachuk/6588-events-data-provider
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 74.59459% with 141 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (66e6db0) to head (fc086df).

Files with missing lines Patch % Lines
engine/access/rest/websockets/controller.go 81.64% 33 Missing and 5 partials ⚠️
.../rest/websockets/data_providers/events_provider.go 73.94% 22 Missing and 9 partials ⚠️
...ockets/data_providers/account_statuses_provider.go 76.78% 18 Missing and 8 partials ⚠️
utils/concurrentticker/concurrent_ticker.go 0.00% 16 Missing ⚠️
.../rest/websockets/data_providers/blocks_provider.go 52.63% 6 Missing and 3 partials ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 8 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 8 Missing ⚠️
...ckets/data_providers/mock/data_provider_factory.go 40.00% 3 Missing ⚠️
...e/access/rest/websockets/data_providers/factory.go 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6817      +/-   ##
==========================================
+ Coverage   41.01%   41.13%   +0.12%     
==========================================
  Files        2104     2108       +4     
  Lines      185030   185460     +430     
==========================================
+ Hits        75892    76297     +405     
+ Misses     102767   102752      -15     
- Partials     6371     6411      +40     
Flag Coverage Δ
unittests 41.13% <74.59%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Implement inactivity tracker
6 participants