Fix getFlowVersion (#235)

onflow · May 23, 2024 · 1b630d2 · 1b630d2
1 parent 6e74d86
commit 1b630d2
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/.changeset/nasty-otters-chew.md b/.changeset/nasty-otters-chew.md
@@ -0,0 +1,5 @@
+---
+"@onflow/flow-js-testing": patch
+---
+
+Add fallback for version checking CLI when JSON not supported
diff --git a/src/utils.js b/src/utils.js
@@ -52,8 +52,18 @@ export async function getFlowVersion(flowCommand = "flow") {
           "Could not determine Flow CLI version, please make sure it is installed and available in your PATH"
         )
       } else {
-        const versionStr = JSON.parse(stdout).version
-        const version = semver.parse(versionStr)
+        let versionStr
+        try {
+          versionStr = JSON.parse(stdout).version
+        } catch (error) {
+          // fallback to regex for older versions of the CLI without JSON output
+          const rxResult = /^Version: ([^\s]+)/m.exec(stdout)
+          if (rxResult) {
+            versionStr = rxResult[1]
+          }
+        }
+
+        const version = versionStr ? semver.parse(versionStr) : undefined
         if (!version) {
           reject(`Invalid Flow CLI version string: ${versionStr}`)
         }