This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
Fix passing numbers as values deprecation notice #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
@onflow/types Deprecation Notice: Passing in Number as value for UInt32 is deprecated
for internal tests, except forexamples/101-pass-int-dictionary.test.js
asflow-cadut
seems to convert numeric dictionary keys to integers while javascript always handles them as strings.More information about the deprecation https://github.com/onflow/fcl-js/blob/master/packages/types/WARNINGS.md
For contributor use:
master
branchFiles changed
in the Github PR explorer