Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix passing numbers as values deprecation notice #188

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

adbario
Copy link
Contributor

@adbario adbario commented Sep 19, 2022

Description

Fixes the @onflow/types Deprecation Notice: Passing in Number as value for UInt32 is deprecated for internal tests, except for examples/101-pass-int-dictionary.test.js as flow-cadut seems to convert numeric dictionary keys to integers while javascript always handles them as strings.

More information about the deprecation https://github.com/onflow/fcl-js/blob/master/packages/types/WARNINGS.md


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation - no relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@adbario adbario requested a review from a team as a code owner September 19, 2022 20:58
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: 1eae9ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adbario adbario changed the title Fix/deprecated numbers as values Fix passing numbers as values deprecation notice Sep 19, 2022
@gregsantos gregsantos merged commit f905016 into onflow:master Oct 24, 2022
This was referenced Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants