Skip to content

Commit

Permalink
Code rabbit comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lealobanov committed Oct 16, 2024
1 parent b6cc5ed commit 332ed19
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions sdk/src/main/kotlin/org/onflow/flow/sdk/models.kt
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,7 @@ data class FlowTransaction(
get() {
return signerList
.withIndex()
.map { it.value to it.index }
.toMap()
.associate { it.value to it.index }
}

companion object {
Expand Down Expand Up @@ -612,7 +611,7 @@ data class FlowTransactionSignature(
fun of(value: TransactionOuterClass.Transaction.Signature): FlowTransactionSignature =
FlowTransactionSignature(
address = FlowAddress.of(value.address.toByteArray()),
signerIndex = value.keyId,
signerIndex = value.keyId ,
keyIndex = value.keyId,
signature = FlowSignature(value.signature.toByteArray())
)
Expand Down Expand Up @@ -1468,6 +1467,14 @@ data class FlowNodeVersionInfo(
.setProtocolVersion(protocolVersion)
.setSporkRootBlockHeight(sporkRootBlockHeight)
.setNodeRootBlockHeight(nodeRootBlockHeight)
.setCompatibleRange(
compatibleRange?.let {
NodeVersionInfoOuterClass.CompatibleRange.newBuilder()
.setStartHeight(it.startHeight)
.setEndHeight(it.endHeight)
.build()
}
)

override fun equals(other: Any?): Boolean {
if (this === other) return true
Expand Down

0 comments on commit 332ed19

Please sign in to comment.