Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#110/ CollectionGuarantee type differs from protobuf schema #118

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Oct 9, 2024

Closes: #110

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@lealobanov lealobanov changed the base branch from main to get-node-version-info-protobuf-schema October 9, 2024 10:14
Copy link

github-actions bot commented Oct 9, 2024

Unit Test Results

0 files   -   54  0 suites   - 54   0s ⏱️ -23s
0 tests  - 316  0 ✔️  - 316  0 💤 ±0  0 ❌ ±0 

Results for commit 11f2ad5. ± Comparison against base commit f8afbfb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 9, 2024

Integration Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 11f2ad5. ± Comparison against base commit f8afbfb.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov marked this pull request as ready for review October 9, 2024 10:20
Copy link

github-actions bot commented Oct 9, 2024

SDK Examples Unit Test Results

37 files  ±0  37 suites  ±0   6m 14s ⏱️ -5s
70 tests ±0  69 ✔️  - 1  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit fbd0e87. ± Comparison against base commit f8afbfb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 9, 2024

Common Integration Test Results

0 files   - 1  0 suites   - 1   0s ⏱️ -7s
0 tests  - 1  0 ✔️  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit fbd0e87. ± Comparison against base commit f8afbfb.

♻️ This comment has been updated with latest results.

@franklywatson franklywatson self-requested a review October 15, 2024 18:29
#111, #113/ Updating models related to FlowBlock
@lealobanov lealobanov merged commit 3217387 into get-node-version-info-protobuf-schema Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectionGuarantee type differs from protobuf schema
2 participants