Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get account balance endpoints #134

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Get account balance endpoints #134

merged 6 commits into from
Oct 23, 2024

Conversation

lealobanov
Copy link
Collaborator

@lealobanov lealobanov commented Oct 21, 2024 •
edited
Loading

Closes: #123

Description

  • Add GetAccountBalanceAtLatestBlock and GetAccountBalanceAtBlockHeight methods to FlowAccessApi
  • Add GetAccountBalanceAtLatestBlock and GetAccountBalanceAtBlockHeight methods to AsyncFlowAccessApi
  • Update unit tests for FlowAccessApi and AsyncFlowAccessApi
  • Update integration tests for FlowAccessApi and AsyncFlowAccessApi
  • Add examples for both methods

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Unit Test Results

  62 files  ±  0    62 suites  ±0   24s ⏱️ -1s
358 tests +12  358 ✔️ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 397339e. ± Comparison against base commit 1f4ab77.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Integration Test Results

  6 files  +  6    6 suites  +6   2m 49s ⏱️ + 2m 49s
33 tests +33  33 ✔️ +33  0 💤 ±0  0 ❌ ±0 

Results for commit 397339e. ± Comparison against base commit 1f4ab77.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

SDK Examples Unit Test Results

39 files  +2  39 suites  +2   6m 49s ⏱️ +31s
76 tests +6  76 ✔️ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 397339e. ± Comparison against base commit 1f4ab77.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Common Integration Test Results

1 files  ±0  1 suites  ±0   7s ⏱️ ±0s
1 tests ±0  1 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 397339e. ± Comparison against base commit 1f4ab77.

♻️ This comment has been updated with latest results.

@lealobanov lealobanov changed the title WIP: Get account balance endpoints Get account balance endpoints Oct 23, 2024
@lealobanov lealobanov marked this pull request as ready for review October 23, 2024 08:36
@lealobanov lealobanov self-assigned this Oct 23, 2024
@franklywatson franklywatson merged commit 5e02ad8 into block-seal-protobuf Oct 23, 2024
6 checks passed
@franklywatson franklywatson deleted the get-account-balance branch October 23, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklywatson franklywatson franklywatson approved these changes

Assignees

@lealobanov lealobanov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lealobanov @franklywatson