Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add limit to project readme #233

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Conversation

MaxStalker
Copy link
Contributor

@MaxStalker MaxStalker commented Feb 28, 2022

Closes: #230
Closes: #218

Testing Plan

  • Set smaller limit on MAX_DESCRIPTION_SIZE constant in src/containers/Editor/components.tsx file. When you put more content that you allowed you should see changes in the input block. Changes won't be saved until the content is smaller than MAX_DESCRIPTION_SIZE
  • Try to input anything in readme field. Should keep focus on the input block.
  • Try to delete all the content. Placeholder would be blank. There is no immediate solution to placeholder problem 🤷

@vercel
Copy link

vercel bot commented Feb 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-playground/FJzz7Q1SPViyvxF1RQzBqoxYxeZW
✅ Preview: https://flow-playground-git-max-218-project-description-limit-onflow.vercel.app

@@ -247,7 +247,7 @@
},

// func walltime() (sec int64, nsec int32)
"runtime.walltime": (sp) => {
"runtime.walltime1": (sp) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, language server was looking for that specific one.

Here's example of similar issue:
maxence-charriere/go-app#569

I believe, I've fixed this issue before, but for some reason it reappeared 🤷‍♂️

@MaxStalker MaxStalker merged commit 23d7fdf into master Feb 28, 2022
@MaxStalker MaxStalker deleted the max/218-project-description-limit branch February 28, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description is losing focus on entry Limit project description to 1mb
2 participants