-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add confirm prompt to control panel #253
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looking good! One small note: Would consider changing up the color scheme a bit to something like this for UX: ^ IE. A neutral outline on the cancel, and a red for destructive action ('Confirm'). The text could be red and the warning icon could be yellow. |
Updated the UI based on @srinjoyc 's recommendations |
Well done, @neilZon ! |
switch (true) { | ||
case isOk && showPrompt: | ||
statusIcon = ( | ||
<FaExclamationTriangle style={{ color: theme.colors.warning }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to set color of this one here:
flow-playground/src/components/Arguments/styles.tsx
Lines 109 to 124 in d385f01
export const ControlContainer = styled.div<ControlContainerProps>` | |
display: flex; | |
align-items: center; | |
justify-content: space-between; | |
color: ${({ isOk, progress }) => { | |
switch (true) { | |
case progress: | |
return '#a2a2a2'; | |
case isOk: | |
return '#2bb169'; | |
default: | |
return '#EE431E'; | |
} | |
}}; | |
`; | |
@MaxStalker how does this look? |
I have a big +1 to not use green text and use red instead, to make the warning stand out |
I think @MaxStalker 's recommendation is better since we are taking up less space with the prompt message so I'll probably go that way |
Heres what it should look like now @MaxStalker @kerrywei @srinjoyc |
Closes: #38
Description
Add prompt to ControlPanel component warning user that redeploying account will reset account states instead of using the native browser
confirm
methodFor contributor use:
Files changed
in the Github PR explorer