Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction/script rename bug #338

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix transaction/script rename bug #338

merged 1 commit into from
Sep 22, 2022

Conversation

alse
Copy link
Contributor

@alse alse commented Sep 21, 2022

setEditing was being triggered twice. The useEffect was unnecessary, onBlur already handles saving the changes


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
flow-playground ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 6:55PM (UTC)

@alse alse changed the title Fix rename bug Fix transaction/script rename bug Sep 21, 2022
Copy link
Contributor

@MrDSGC MrDSGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alse alse merged commit e1c40d9 into staging Sep 22, 2022
@alse alse deleted the as/fix-rename-bug branch September 22, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants