Action button bug fixes #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alse
force-pushed
the
as/action-button-bug-fixes
branch
from
12b96c8 to
75500a2
Compare
This is a temporary solution, we'll be switching to Apollo 3 and mutation hooks
alse
force-pushed
the
as/action-button-bug-fixes
branch
from
75500a2 to
17c39b7
Compare
MrDSGC
approved these changes
Sep 23, 2022
| const { isSavingCode } = useProject(); | ||
| const sendingTransaction = false; | ||
|
|
||
| const code = getActiveCode()[0].trim(); |
There was a problem hiding this comment.
will this fatal if getActiveCode() returns undefined?
There was a problem hiding this comment.
getActiveCode is typed as a [string, number] tuple so it seems like that shouldn't happen. However, since typescript assumes accessing an array always returns a value, it would technically be possible. I updated the default values, and we should consider setting noUncheckedIndexedAccess: true in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution, we'll be switching to Apollo 3 and mutation hooks
For contributor use:
Files changedin the Github PR explorer