Allow pre-release CLI versions #458

jribbink · 2023-10-27T22:43:57Z

Closes #446

Description

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

turbolent · 2023-10-28T00:01:00Z

extension/src/dependency-installer/installers/flow-cli-installer.ts

@@ -100,7 +100,9 @@ export class InstallFlowCLI extends Installer {
    const version = vsn ?? await flowVersion.getValue(true)
    if (version === null) return false

-    if (!semver.satisfies(version, COMPATIBLE_FLOW_CLI_VERSIONS)) {
+    if (!semver.satisfies(version, COMPATIBLE_FLOW_CLI_VERSIONS, {
+      includePrerelease: true


Allow pre-release CLI versions

cd6bae0

jribbink requested a review from nialexsan October 27, 2023 22:44

chasefleming approved these changes Oct 27, 2023

View reviewed changes

jribbink merged commit 50c2b43 into master Oct 27, 2023
8 checks passed

jribbink deleted the jribbink/semver-prerelease branch October 27, 2023 23:50

turbolent reviewed Oct 28, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow pre-release CLI versions #458

Allow pre-release CLI versions #458

jribbink commented Oct 27, 2023 •

edited

Loading

turbolent Oct 28, 2023

Allow pre-release CLI versions #458

Allow pre-release CLI versions #458

Conversation

jribbink commented Oct 27, 2023 • edited Loading

Description

turbolent Oct 28, 2023

Choose a reason for hiding this comment

jribbink commented Oct 27, 2023 •

edited

Loading