Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero width and height when creating CircleIndicator programmatically. #17

Closed
tido64 opened this issue Jun 1, 2015 · 2 comments
Closed

Zero width and height when creating CircleIndicator programmatically. #17

tido64 opened this issue Jun 1, 2015 · 2 comments

Comments

@tido64
Copy link

tido64 commented Jun 1, 2015

Creating a CircleIndicator without an AttributeSet does not properly set the width, height, and margin of the indicators:

        CircleIndicator indicator = new CircleIndicator(getActivity());

Because handleTypedArray() only sets default values when mIndicatorWidth/mIndicatorHeight/mIndicatorMargin < 0 but they're not set in any constructor.
@tido64
Copy link
Author

tido64 commented Jun 1, 2015

I guess the same goes for all the other properties but I never got so far as to see the indicators on-screen.

@ongakuer
Copy link
Owner

ongakuer commented Jun 2, 2015

Sorry, I forgot this case…
I will fix it soon.

ongakuer pushed a commit that referenced this issue Jun 3, 2015
1. Fix bug #17 ;
1cce824 
2. SetOnPageChangeListener deprecated;
@ongakuer ongakuer closed this as completed Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ongakuer @tido64