-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Godot 4 compatible branch #30
Comments
@oniksan Could you help me to fix the last few bits? :) |
@kelteseth, Hi! Sorry, I have not studied Godot 4 and don't know what changes have been made regarding the language constructs of GDScript, therefore, I cannot answer your question now. Unfortunately, the Godot developers for some reason do not think about backward compatibility at all. Regarding |
@oniksan I just tested it with the current Godot nightly from https://hugo.pro/projects/godot-builds/ and it seems that |
godot_LjbHsKtXl6.mp4@oniksan should be all fixed now. Should I create a PR? kelteseth@7e501da |
I fixed the duplicate PROTO_VERSION and ported some unit tests. Not sure how to port:
because Godot 4 required actual object references (not sure if this is true). @oniksan would you be willing to help me so we can merge this? |
Hi, @kelteseth I think that before the release of stable version 4, it's not worth changing anything and people are using the stable version of Godot and want to use the appropriate stable Godobuf version. |
Hello,Godot 4.0 RC is released. Is there any plan to add Godot 4 compatible branch? Thanks. |
Hi, rather yes than no :) |
Just wanted to 👍 this issue, now that Godot 4.0 has released. Is there anything the community can do to contribute? Thanks! |
I am willing to help if needed. @kelteseth does your branch still work with 4.0 stable? |
@TheDarkUndoing I will have to test it again and probably with teste changes https://github.com/kelteseth/godobuf/pulls |
@oniksan Godot 4 fork is now ready. Thanks to @xiyoo0812 & @cmdrk for their fixes. Should I create a PR now? Also can I update the logo to include the protobof logo with the Godot mascot? 😊 |
Sorry, I don't have time yet, you can do a PR, I'll see how it will be possible. |
@oniksan Godot 4 Object now also has as to_string function: What should we name it? |
@kelteseth We should override the object's to_sting() if possible. Or does the to_string object's method have a different purpose? |
Can I help with porting this to gd4 somehow? |
Hi all. https://github.com/oniksan/godobuf/releases/tag/v0.6.0 |
Hi,
I adapted most of the API changes in my fork of godobuf. It is not ready yet to be merged but you can take a look at the changes
https://github.com/kelteseth/godobuf
Godot API Changes:
Buggy:
Not working:
protobuf_core.gd
line 106 and 109 error when usingconst
with[]
. No idea how to solve this.This next one looks similar to #26
The text was updated successfully, but these errors were encountered: