Fixed msbuild holding dll lock during AttributeProcessor task #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polycone
requested changes
Oct 20, 2023
src/MultiplayerMod.AttributeProcessor.MSBuild.Task/ProcessAttributes.cs
Outdated
Show resolved
Hide resolved
polycone
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, on my machine, building the solution failed while running the
AttributeProcessorMSBuild task. The issue being that msbuild.exe held a reference to theMultiplayerMod.Original.dllfile after opening withModuleDefMD.Load(). It would then fail to delete the file during cleanup. I've simply changed it to open a stream and close it after reading the file. I figured I couldn't be the only one this is affecting. Though in all probability it's something to do with my build environment. Figured I'd throw this up here in case you're interested.VS2022
x64
Windows 10
Love the mod!