Markdown changes #2282
Markdown changes #2282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2282 +/- ##
==========================================
+ Coverage 37.34% 37.34% +<.01%
==========================================
Files 298 298
Lines 12351 12352 +1
Branches 1632 1632
==========================================
+ Hits 4612 4613 +1
Misses 7490 7490
Partials 249 249
Continue to review full report at Codecov.
|
Before the fix was only applied to close.
|
I'm going to swap this back to WIP and add a fix for the highlighting issue as well (#1277). |
|
This PR is waiting on my other PR in |
|
Looks good to me, @CrossR ! Thanks for the fixes here 😄 I just brought in the oni-api changes - bumping the version so we can get a new NPM package for it. |
|
Alright, looks like the new |
…ownChanges # Conflicts: # package.json
…ownChanges # Conflicts: # browser/src/Services/Browser/index.tsx
|
Just fixing the merge conflict, then this should be fine to review/merge. I've got a second Markdown PR to add syntax highlighting and fix relative paths for images, but I split that into a second PR as it was waiting on my PR to DefinitelyTyped to update the Marked type defs. I'll stick that up soon. |
| @@ -242,6 +242,11 @@ export function createWindow( | |||
| Log.info("...closed event completed") | |||
| }) | |||
|
|
|||
| currentWindow.webContents.on("will-navigate", (event, url) => { | |||
| event.preventDefault() | |||
| currentWindow.webContents.send("open-oni-browser", url) | |||
There was a problem hiding this comment.
One minor thing - we may not actually need a new ipc message in this case. I think we could use the execute-command one we have, along with the browser.openUrl action, something like:
currentWindow.webContents.send("execute-command", "browser.openUrl", url)
We do something similar in the menu:
Line 50 in 16c2eb5
|
Just had one minor item but not a blocker - change looks great to me! 👍 🎉 Thanks @CrossR ! |
|
I'll bring this in now and address the PR comment in my other markdown changes so this can be tested a bit. |
|
Sweet! Thanks @CrossR! 💯 |
A few tiny Markdown preview changes, to make the preview experience a bit more consistent.
Fixes #1277, #2021.
Would you be able to take a look over @TalAmuyal ?
EDIT: Now depends on a pending PR on oni-api due to the API changes for the focus / active split.