Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input: Add Control+PageUp/Control+PageDown to switch between open files #778

Closed
bryphe opened this issue Sep 22, 2019 · 5 comments · Fixed by #1447
Closed

Input: Add Control+PageUp/Control+PageDown to switch between open files #778

bryphe opened this issue Sep 22, 2019 · 5 comments · Fixed by #1447
Labels
A-configuration Area: Configuration, settings, options, preferences etc. A-workspace Area: Overall UX, editor layout, tabs/groups/splits etc. enhancement New feature or request

Comments

@bryphe
Copy link
Member

bryphe commented Sep 22, 2019 •
edited
Loading

Feedback from discord - we should add Control+PageUp / Control+PageDown as default bindings for switching between opened files.

Is this the same default on OSX?
@bryphe bryphe added enhancement New feature or request A-input Area: Input management, keyboard layout, IME etc. labels Sep 22, 2019
@dereknelson
Copy link

I personally would prefer cmd+shift+[ / cmd+shift+] to move left and right, this behavior is shared with chrome and discord

@bryphe
Copy link
Member Author

bryphe commented Oct 2, 2019

@jordwalke mentioned the same request on Discord - have cmd+shift+[ switch between tabs.

@paskausks
Copy link

In case of discord, I use ctrl+alt+arrow up / ctrl+alt+arrow up to switch servers, but for firefox/chrome I'm, personally in the ctrl+pgup / ctrl+pgdn crowd, so, personally, I'm for that as default, instead of ctrl+shift+[ / ctrl+shift+].

@glennsl glennsl added A-workspace Area: Overall UX, editor layout, tabs/groups/splits etc. and removed A-input Area: Input management, keyboard layout, IME etc. labels Nov 18, 2019
@jamesgecko
Copy link

ctrl+pgup / ctrl+pgdown is a Windows shortcut. The macOS convention for switching tabs is cmd+shift+[ / cmd+shift+]. Ideally both would work; Firefox supports both keybindings on macOS.

@glennsl glennsl added the A-configuration Area: Configuration, settings, options, preferences etc. label Mar 6, 2020
@glennsl glennsl mentioned this issue Mar 6, 2020
Open
@leavengood
Copy link
Contributor

I have this working, with both shortcuts, I will open a PR today.

leavengood added a commit to leavengood/oni2 that referenced this issue Mar 8, 2020
@leavengood
Implement the next/previous editor commands and keybindings
6a9ac8e 
This wraps around like VSCode.

Fixes onivim#778 and part of onivim#1423.
@leavengood leavengood mentioned this issue Mar 8, 2020
Merged
leavengood added a commit to leavengood/oni2 that referenced this issue Mar 8, 2020
@leavengood
Implement the next/previous editor commands and keybindings
95dc0f0 
This wraps around like VSCode.

Fixes onivim#778 and part of onivim#1423.
bryphe pushed a commit that referenced this issue Mar 10, 2020
@leavengood
Implement the next/previous editor commands and keybindings (#1447)
39477a2 
* Implement the next/previous editor commands and keybindings

This wraps around like VSCode.

Fixes #778 and part of #1423.

* Remove unneeded new actions

* Adjust how the next/previous editor code works in EditorGroup

Resolve the TODO for _getIndexOfElement by making it return option(int).
List.find_opt is not actually the right choice to get an index.

Also ran `esy format`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-configuration Area: Configuration, settings, options, preferences etc. A-workspace Area: Overall UX, editor layout, tabs/groups/splits etc. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the next/previous editor commands and keybindings leavengood/oni2
6 participants
@leavengood @jamesgecko @glennsl @paskausks @dereknelson @bryphe