feat(keybindings): add binding for opening config #3352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @LiHRaM , Sorry for the slow reply! Thank you for the PR, really appreciate the contribution 🎉 Made a couple small tweaks; but when CI is green, will merge. |
bryphe
reviewed
Apr 1, 2021
| let command = Commands.openConfigurationFile.id; | ||
|
|
||
| let openConfigOnMac = | ||
| bind(~key="<D-,>", ~condition="isMac" |> WhenExpr.parse, ~command); |
There was a problem hiding this comment.
I believe the condition is case-sensitive (which may be a bug itself) - flipped from IsMac -> isMac.
bryphe
reviewed
Apr 1, 2021
| bind(~key="<D-,>", ~condition="isMac" |> WhenExpr.parse, ~command); | ||
|
|
||
| let openConfigOnOther = | ||
| bind(~key="<C-,>", ~condition="!isMac" |> WhenExpr.parse, ~command); |
There was a problem hiding this comment.
I was worried this might conflict with a default Vim keybinding, but doesn't appear that it does 👍
bryphe
reviewed
Apr 1, 2021
| @@ -31,6 +31,7 @@ let defaultKeyBindings = | |||
| ), | |||
| ] | |||
| @ Feature_SideBar.Contributions.keybindings | |||
| @ Feature_Configuration.Contributions.keybindings | |||
|
Looks like the CI failure isn't related to this change; it's a bug with loading the cache. So I'll bring it now. Thanks for the contribution, @LiHRaM - much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listed in #1423 as a good place to get started as adding a keybinding for the "Open Settings" shortcut. Hope it's okay!
(I accidentally force pushed to master when tracking upstream, so setting this to a different branch now. Unfortunately GitHub doesn't seem to allow me to change the tracking downstream branch after opening an issue...)