-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compliance with multiple river features #93
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 74.90% 79.82% +4.91%
==========================================
Files 24 26 +2
Lines 1104 1254 +150
==========================================
+ Hits 827 1001 +174
+ Misses 277 253 -24 ☔ View full report in Codecov by Sentry. |
I adapted some of the code to make sure the models can also deal with emerging, disappearing or shuffled features. The typing and documentation is probably still a bit off here and there, since I don't think I have the right linter to check for that. Maybe you could check it out some time 😅
Cheers,
Lucas