Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compliance with multiple river features #93

Merged
merged 19 commits into from
Aug 21, 2024

Conversation

lucasczz
Copy link
Collaborator

@lucasczz lucasczz commented Aug 6, 2024

I adapted some of the code to make sure the models can also deal with emerging, disappearing or shuffled features. The typing and documentation is probably still a bit off here and there, since I don't think I have the right linter to check for that. Maybe you could check it out some time 😅

Cheers,
Lucas

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kulbachcedric kulbachcedric merged commit e22b65a into master Aug 21, 2024
6 checks passed
@kulbachcedric kulbachcedric deleted the dev_layer_adaptation branch August 21, 2024 20:12
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.91886% with 99 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (20ab012) to head (f07d3c0).
Report is 31 commits behind head on master.

Files Patch % Lines
deep_river/classification/rolling_classifier.py 52.17% 22 Missing ⚠️
deep_river/classification/classifier.py 70.58% 15 Missing ⚠️
deep_river/regression/rolling_regressor.py 51.85% 13 Missing ⚠️
deep_river/utils/layer_adaptation.py 87.62% 12 Missing ⚠️
deep_river/anomaly/ae.py 65.51% 10 Missing ⚠️
deep_river/regression/regressor.py 52.63% 9 Missing ⚠️
deep_river/base.py 88.33% 7 Missing ⚠️
deep_river/anomaly/probability_weighted_ae.py 60.00% 4 Missing ⚠️
deep_river/anomaly/rolling_ae.py 66.66% 4 Missing ⚠️
deep_river/regression/multioutput.py 75.00% 2 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   74.90%   79.82%   +4.91%     
==========================================
  Files          24       26       +2     
  Lines        1104     1254     +150     
==========================================
+ Hits          827     1001     +174     
+ Misses        277      253      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants