Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for NVM if exists as Node dependencies (Node.js Runtime not detected) #853

Closed
whjvenyl opened this issue Dec 6, 2024 · 6 comments · Fixed by #884 or #885
Closed

Check for NVM if exists as Node dependencies (Node.js Runtime not detected) #853

whjvenyl opened this issue Dec 6, 2024 · 6 comments · Fixed by #884 or #885
Assignees
@Kitenite
Labels
bug Something isn't working

Comments

@whjvenyl
Copy link

whjvenyl commented Dec 6, 2024 •
edited
Loading

Node.js runtime is installed with nvm, onlook doesn't pick that one up.

CleanShot 2024-12-06 at 9  41 19@2x
CleanShot 2024-12-06 at 9  42 54@2x
@whjvenyl whjvenyl added the bug Something isn't working label Dec 6, 2024
@Kitenite Kitenite self-assigned this Dec 6, 2024
@Kitenite
Copy link
Contributor

Kitenite commented Dec 6, 2024

Gotcha, will add a check for nvm. Thanks @whjvenyl !

@Kitenite Kitenite changed the title Node.js Runtime not detected Check for NVM if exists as Node dependencies (Node.js Runtime not detected) Dec 9, 2024
@aranwe aranwe mentioned this issue Dec 11, 2024
Closed
This was linked to pull requests Dec 11, 2024
Check npm instead of node #884
Merged
Check for version managers #885
Merged
@Kitenite
Copy link
Contributor

This should now be fixed by checking the paths for different version managers (next release). Please lmk if there's still an issue @whjvenyl

@dvnkshl
Copy link

dvnkshl commented Jan 31, 2025

Has this fix shipped? Having the same issue on MacOS, i just download onlook.

@Kitenite
Copy link
Contributor

@dvnkshl this should've been fixed. I'm testing it on nvm myself without the issue. Could you share your node version and which node?

Image

@dvnkshl
Copy link

dvnkshl commented Feb 3, 2025

it works fine for me now!

@Kitenite
Copy link
Contributor

Kitenite commented Feb 3, 2025

Awesome, glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kitenite Kitenite

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check npm instead of node onlook-dev/onlook
Check for version managers onlook-dev/onlook
3 participants
@whjvenyl @dvnkshl @Kitenite