Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Node.js env detection with fnm@Windows #881

Closed
aranwe opened this issue Dec 11, 2024 · 2 comments · Fixed by #884 or #885
Closed

[bug] Node.js env detection with fnm@Windows #881

aranwe opened this issue Dec 11, 2024 · 2 comments · Fixed by #884 or #885
Labels
bug Something isn't working

Comments

@aranwe
Copy link

aranwe commented Dec 11, 2024 •
edited
Loading

Describe the bug

Onlook cannot detect node.js installed via fnm on Windows (which is one of the currently supported methods of installation for node.js) and asks to install standard non-versioned node binaries.
@aranwe aranwe added the bug Something isn't working label Dec 11, 2024
@aranwe
Copy link
Author

aranwe commented Dec 11, 2024

Similar problem to: #853

This was linked to pull requests Dec 11, 2024
Check npm instead of node #884
Merged
Check for version managers #885
Merged
@Kitenite
Copy link
Contributor

This should now be fixed by checking the paths for different version managers (next release). Please lmk if there's still an issue @aranwe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check npm instead of node onlook-dev/onlook
Check for version managers onlook-dev/onlook
2 participants
@aranwe @Kitenite