Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not clickable outside of stream #1197

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Fix not clickable outside of stream #1197

merged 1 commit into from
Feb 1, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Feb 1, 2025

Description

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses UI interaction issues by fixing button behavior in bash command execution and improving clickable areas in the message stream interface.

  • Added vertical margin (my-2) to loading indicator in /apps/studio/src/routes/editor/EditPanel/ChatTab/ChatMessages/StreamMessage.tsx to prevent blocked click areas
  • Fixed button disable logic in /apps/studio/src/routes/editor/EditPanel/ChatTab/CodeChangeDisplay/BashCodeDisplay.tsx to properly prevent multiple command executions during streaming
  • Corrected the isStream condition to disable buttons while streaming instead of when not streaming

💡 (5/5) You can turn off certain types of comments like style here!

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Kitenite Kitenite merged commit 33824e3 into main Feb 1, 2025
@Kitenite Kitenite deleted the bugs/run-bash-stream branch February 1, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant