Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore fragment in Next plugin #294

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Ignore fragment in Next plugin #294

merged 6 commits into from
Sep 4, 2024

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Sep 4, 2024

Description

We get a warning when data-onlook-id writes to a React.Fragment. Since the Fragment gets stripped anyway, it's not breaking but the red is scary looking

#262

      <React.Fragment>
        <Sidebar />
      </React.Fragment>
Screenshot 2024-09-04 at 9 29 37 AM

What is the purpose of this pull request?

  • New feature
  • Documentation update
  • Bug fix
  • Refactor
  • Release
  • Other

@Kitenite Kitenite linked an issue Sep 4, 2024 that may be closed by this pull request
[Bug] Invalid prop data-onlook-id supplied to React.Fragment. React.Fragment can only have key and children props. #262
Closed
@Kitenite Kitenite merged commit d1b650e into main Sep 4, 2024
@Kitenite Kitenite deleted the features/plugins-ignore-fragment branch September 4, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Kitenite