Add login page #367
Add login page #367
Conversation
Need to swap in a better logo and a better image. Not super well-tested for smaller screen sizes but hoping that our fixed min-width addition will help with how the login screen may appear. Also threw in placeholder logic for the login state.
app/src/App.tsx
Outdated
| return ( | ||
| <ThemeProvider defaultTheme="dark" storageKey="vite-ui-theme"> | ||
| <TooltipProvider> | ||
| <AppBar /> | ||
| {routeManager.route !== Route.LOGIN && <AppBar />} |
There was a problem hiding this comment.
No App Bar means no drag... Could make it black for the occasion?
There was a problem hiding this comment.
No drag? For the rest of the app or what do you mean? I don't quite understand.
There was a problem hiding this comment.
Try dragging the window without the AppBar. You won't be able to drag it if its disabled. So instead, we can make it transparent or black when route is Login. You don't have to do this, I can update it once we agree on an implementation.
There was a problem hiding this comment.
Actually, I updated with what I mean
app/src/assets/Dunes_Login.png
Outdated
There was a problem hiding this comment.
I would reuse the other asset or replace it. Also needs to be compressed. Should be 200kb instead of 2 MB
app/src/routes/login/index.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| // Retrieve the last login method from localStorage | ||
| const storedMethod = localStorage.getItem('lastLoginMethod'); |
There was a problem hiding this comment.
Nice stuff but this is not what we do. I'll update it before merge.
Description
What is the purpose of this pull request?